feat(react-ui-core): add onSwipe* hooks and add --stackflow-swipe-back-ratio css var
#548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back-ratio` css var
🦋 Changeset detectedLatest commit: a1b37eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
malangcat
approved these changes
Dec 18, 2024
Comment on lines
8
to
17
| /** | ||
| * should be rendered in client-side only to avoid hydration mismatch warning | ||
| */ | ||
| ...(mounted | ||
| ? { | ||
| "data-stackflow-activity-id": activity?.id, | ||
| "data-stackflow-activity-is-active": activity?.isActive, | ||
| "data-stackflow-activity-transition-state": activity?.transitionState, | ||
| } | ||
| : null), |
There was a problem hiding this comment.
Hydration Mismatch를 피하기 위해 mounted 상태에서만 렌더링합니다
malangcat
reviewed
Dec 18, 2024
malangcat
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.